Conversation
Databean
requested review from
cjreynol and
jmacnak
and removed request for
cjreynol
September 25, 2026 00:33
In tests it is common to write ```c++ auto value = FunctionReturningResult(); ASSERT_THAT(value, IsOk()); DoSomething(*value); ``` It would be nice to have something like `CF_EXPECT` instead, to write a test as ```c++ auto value = CF_ASSERT(FunctionReturningResult()); DoSomething(value); ``` Sample error: ``` cuttlefish/host/commands/cvd/cli/commands/monitor/kernel_test.cc:31: Failure Value of: macro_intermediate_result Expected: an ok result Actual: 56-byte object <F0-13 F3-FD 07-56 00-00 70-15 F3-FD 07-56 00-00 70-15 F3-FD 07-56 00-00 F8-FB F2-FD 07-56 00-00 40-09 BE-0C FE-7F 00-00 C1-0D D5-47 80-7F 00-00 00-13 F3-FD 07-56 00-00>, which is an error result with trace: | cuttlefish/host/commands/cvd/cli/commands/monitor/kernel.cc:55 v Result<KernelLine> cuttlefish::ParseKernelLine(std::string_view) CF_EXPECT(false) ``` Bug: b/565923720
jmacnak
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tests it is common to write
It would be nice to have something like
CF_EXPECTinstead, to write a test asSample error:
Bug: b/565923720