Repository navigation
fix(runtime): stop the Windows daemon from opening a visible console - #173
Open
Silversun31 wants to merge 1 commit into
Open
Silversun31 wants to merge 1 commit into
Silversun31 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Windows ignores CREATE_NO_WINDOW when it is combined with DETACHED_PROCESS. The venv python.exe is a launcher, so the real interpreter it starts got a new visible console, and closing that window killed the server. Fixes google#172
Silversun31
force-pushed
the
fix/windows-daemon-console-window
branch
from
October 6, 2026 20:08
6751a6e to
4097919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
Windows ignores
CREATE_NO_WINDOWwhen it is combined withDETACHED_PROCESS. The venvpython.exeis a launcher, so the real interpreter it starts got a new visible console, andclosing that window killed the server.
spawn_daemonnow usesCREATE_NEW_PROCESS_GROUP | CREATE_NO_WINDOW, the same flags theworker processes already use (
apps/admin_console/services/worker_process_io.py). The daemonstill outlives the terminal that started it.
test_spawn_daemonasserts the flags on Windows; it fails on the previous code.Tested on Windows 11 with a uv venv:
uv run artemis restart --no-openno longer shows a windowand the API answers.
ruff format --check,ruff check,scripts/quality_ratchet.py,pyright --project pyright-core.jsonandpytest(2528 passed) are clean.🤖 Generated with Claude Code