test(service): the asset readiness invariant includes files and reconcile - #270
Merged
Merged
Conversation
…cile Release run 36361892126 failed only on test_assets_reports_ready_when_all_present: ready=False while every boot asset was present, because the service's startup reconcile was still fetching the profile's software-inventory.json (downloading=True). That is the product contract: ready covers the profile's files as well as its assets, and an in-flight reconcile reports ready=False until it publishes a fresh snapshot (profile_status_cache::refresh_reconcile_fields). The test read only `assets`, so it raced the startup reconcile.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=========================================
- Coverage 65.3% 65.3% -0.1%
=========================================
Files 1452 1452
Lines 127965 127965
Branches 91872 91872
=========================================
- Hits 83614 83610 -4
Misses 39361 39361
- Partials 4990 4994 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 36361892126 failed only on
test_assets_reports_ready_when_all_present: ready=False while every boot
asset was present, because the service's startup reconcile was still
fetching the profile's software-inventory.json (downloading=True). That is
the product contract: ready covers the profile's files as well as its
assets, and an in-flight reconcile reports ready=False until it publishes a
fresh snapshot (profile_status_cache::refresh_reconcile_fields). The test
read only
assets, so it raced the startup reconcile.Blocks the 0.6.4 stable release (fix forward; unchanged retries are refused).
🤖 Generated with Claude Code