fix(release): an installed package is checked for the binaries it ships - #273
Merged
Merged
Conversation
Release run 36371330940 failed its installed glow-up: after installing the published 0.6.3 package, the probe checked every current host binary name for version 0.6.3 and stopped at `test -x ~/.capsem/bin/capsem-router`. 0.6.3 never had it -- the companion was capsem-port-router until the rename -- so a binary-set change between releases made every upgrade proof from the previous release fail. The exact probe now takes each package's binaries from its own payload (packaged_host_binaries), and the public transition check from what the installed package owns (dpkg -L). The candidate still ships every current binary, which build-linux-package.sh already asserts.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=========================================
+ Coverage 65.3% 65.4% +0.1%
=========================================
Files 1452 1450 -2
Lines 127965 127649 -316
Branches 91872 91731 -141
=========================================
- Hits 83611 83567 -44
+ Misses 39362 39140 -222
+ Partials 4992 4942 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 36371330940 failed its installed glow-up: after installing the
published 0.6.3 package, the probe checked every current host binary name
for version 0.6.3 and stopped at
test -x ~/.capsem/bin/capsem-router.0.6.3 never had it -- the companion was capsem-port-router until the
rename -- so a binary-set change between releases made every upgrade proof
from the previous release fail.
The exact probe now takes each package's binaries from its own payload
(packaged_host_binaries), and the public transition check from what the
installed package owns (dpkg -L). The candidate still ships every current
binary, which build-linux-package.sh already asserts.
Blocks the 0.6.4 stable release (fix forward). Tests: new payload and public-transition behavioural tests fail before, pass after; checked against real 0.6.2/0.6.3 packages; release/packaging suites show only the known environmental release-site failures; citadel 1255, ruff and capsem-gate lint clean.
🤖 Generated with Claude Code