Repository navigation
Conversation
This was referenced Nov 5, 2026
Xeicker
force-pushed
the
feature/swarming/pr2-add-task-platform-queue
branch
from
November 6, 2026 03:08
9261f29 to
0031e7d
Compare
IvanBM18
approved these changes
Nov 6, 2026
| external_tasks.add_external_task(command, argument, job) | ||
| return | ||
|
|
||
| if queue is None and swarming.is_swarming_applicable(job_type, job=job): |
Collaborator
There was a problem hiding this comment.
This logic introduces a side effect to the callers of the add_task() method, so to let callers know of this, Can you mention this sidefffect at the method's pydoc string?
# Conflicts: # src/clusterfuzz/_internal/tests/core/base/tasks/tasks_test.py
Xeicker
force-pushed
the
feature/swarming/pr2-add-task-platform-queue
branch
from
November 9, 2026 17:15
5b267dc to
0aa1c28
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 574630499
Stack: #5581 → #5582 (this) → #5583. See #5581 for context.
Description
Most non-fuzz tasks are created via
tasks.add_task()without a queue, so they landed in the creator's default queue (e.g.jobs-linux) and never reached the dedicated tworker.add_tasknow resolves the platform queue for Swarming jobs when no queue is given, instead of changing every call site. Explicit queues are kept.Testing