Repository navigation
Scan FuzzTargetJob in key order instead of by last_run in cleanup - #5585
Open
ViniciustCosta wants to merge 1 commit into
Open
ViniciustCosta wants to merge 1 commit into
ViniciustCosta wants to merge 1 commit into
Conversation
Fuzz tasks constantly rewrite FuzzTargetJob.last_run, which makes last_run-filtered queries frequently exceed the Datastore deadline and lets a last_run DESC paginated scan skip entities whose index position moves mid-scan, causing valid FuzzTargets to be deleted. Read the whole kind once in key order and apply the cutoff client-side, as suggested by the Datastore team in b/418807403#comment21. Bug: b/581523363, b/406250205
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Fuzz tasks constantly rewrite FuzzTargetJob.last_run, which makes last_run-filtered queries frequently exceed the Datastore deadline and lets a last_run DESC paginated scan skip entities whose index position moves mid-scan, causing valid FuzzTargets to be deleted.
Tentative fix: Read the whole kind once in key order and apply the cutoff client-side, as suggested by the Datastore team in b/418807403#comment21. The kind is small and the previous
<and>=queries already read all of it. Behavior is otherwise unchanged, since entities withlast_run = Nonestill match neither branch (neither deleted nor treated as valid).Testing: Added unit testing. However, a live test is currently not possible since we don't support the cleanup cronjob in the development environment.
Bug: b/581523363, b/406250205