Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
progression_taskfrom falsely marking open testcases asFixedwhen a candidate build fails to start due to missing shared libraries or ABI symbol mismatches on the worker OS (e.g., during base OS migrations such as Ubuntu 24.04).Details
_is_fatal_execution_or_linker_failureto detect:126and127), anderror while loading shared libraries:,cannot open shared object file, andGLIBC_/GLIBCXX_/CXXABI_versionnot founderrors), even afterreproduce_with_retriesnormalizes the finalCrashResult.return_codeto0.BuildData.is_bad_build = Trueand returnsErrorType.PROGRESSION_BAD_BUILDin both_testcase_reproduces_in_revisionand_check_fixed_for_custom_binaryinstead of proceeding to_save_fixed_range.progression_task_test.py.