Refactor FlatbuffersTableUntypedDomainImpl::MutateSelectedField to use a visitor and clean up CountNumberOfMutableFieldsVisitor.#2072
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
cl/921337267
branch
2 times, most recently
from
d4e0ab3 to
d0d5b65
Compare
copybara-service
Bot
force-pushed
the
cl/921337267
branch
2 times, most recently
from
a7e309d to
2580c08
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/921337267
branch
7 times, most recently
from
4c1aac9 to
204bf3c
Compare
…e a visitor and clean up CountNumberOfMutableFieldsVisitor. Specifically: * Introduce `MutateSelectedFieldVisitor` to encapsulate mutation logic for specific field indices, passing nested table recursion through the visitor pattern. * Clean up `CountNumberOfMutableFieldsVisitor` and rename fields (`total_weight` -> `field_count`, `val` -> `corpus_value`) to better reflect their semantic meaning. * Limit recursive mutations and field counting to nested tables (`FlatbuffersTableTag`) via `std::is_same_v` constexpr checks. * Add TODO markers referencing b/418993255 for extending support to structs, unions, and containers of these types. PiperOrigin-RevId: 921337267
copybara-service
Bot
force-pushed
the
cl/921337267
branch
from
204bf3c to
fd6ee2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor FlatbuffersTableUntypedDomainImpl::MutateSelectedField to use a visitor and clean up CountNumberOfMutableFieldsVisitor.
Specifically:
MutateSelectedFieldVisitorto encapsulate mutation logic for specific field indices, passing nested table recursion through the visitor pattern.CountNumberOfMutableFieldsVisitorand rename fields (total_weight->field_count,val->corpus_value) to better reflect their semantic meaning.FlatbuffersTableTag) viastd::is_same_vconstexpr checks.