Add stop request reason and separate stop request and set stop time reset.#2106
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add stop request reason and separate stop request and set stop time reset.#2106copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…eset. The separation is because we want to reset stop request only when when know that the early stop is already requested, otherwise there is a window between checking early stop and resetting early stop where requests issued in-between (mainly from the signal handlers) would be ignored. PiperOrigin-RevId: 937374916
copybara-service
Bot
force-pushed
the
cl/937374916
branch
from
29744a6 to
5705045
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stop request reason and separate stop request and set stop time reset.
The separation is because we want to reset stop request only when when know that the early stop is already requested,
otherwise there is a window between checking early stop and resetting early stop where requests issued in-between (mainly from the signal handlers) would be ignored.