Skip to content

refactor!: Update teams create & update patterns - #4446

Open
stevehipwell wants to merge 3 commits into
google:masterfrom
stevehipwell:refactor-teams-create-update
Open

refactor!: Update teams create & update patterns#4446
stevehipwell wants to merge 3 commits into
google:masterfrom
stevehipwell:refactor-teams-create-update

Conversation

@stevehipwell

@stevehipwell stevehipwell commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: CreateTeam and UpdateTeamBy* now take new body params by value.

This PR updates the teams create and update patterns to use the new request naming with seperate requests for create and update and adds support for linking parent teams by slug.

On the create path we've added the new ParentTeamSlug field and removed the unsupported LDAPDN field. On the update path we've removed added the new ParentTeamSlug field and a RemoveParentTeam field to replace the boolean in the method signature, as well as making Name optional and removing the unsupported Maintainers, RepoNames & LDAPDN fields.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Aug 12, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear - @Not-Dhananjay-Mishra

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (848675f) to head (d9445fd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4446      +/-   ##
==========================================
- Coverage   97.55%   97.55%   -0.01%     
==========================================
  Files         194      194              
  Lines       19892    19884       -8     
==========================================
- Hits        19406    19398       -8     
  Misses        268      268              
  Partials      218      218              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

gmlewis commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@stevehipwell - please see if you can improve the codecov results for this PR or let me know if you need assistance.

Comment thread github/teams.go Outdated
@stevehipwell

Copy link
Copy Markdown
Contributor Author

@stevehipwell - please see if you can improve the codecov results for this PR or let me know if you need assistance.

@gmlewis that was an oversight on my behalf as it looks like non-exported types don't get stringify tests generated, however with the change suggested by @alexandear that whole type will be removed anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants