Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4605 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 198 198
Lines 18552 18555 +3
=======================================
+ Hits 18294 18297 +3
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Is this PR fixing a hypothetical issue that has never been emperically found in the wild, or has this problem ever been actually seen when using this client library? When would a relative URL ever be returned by GitHub? How has this client library been working for decades without ever encountering a relative URL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Relative
Locationvalues are resolved against the responding request URL; using the API base URL can discard the endpoint path or return an unusable relative URL. This followshttp.Response.Location.Validation
bash script/test.sh ./...— all 11 modules passed.go vet ./...— passed.gofmtandgit diff --checkpassed.script/lint.shreached the generated-file check, which reports the localgo.sumCRLF/LF mismatch; no unrelated line-ending change is included.AI assistance
AI assistance helped draft the implementation and regression tests; the contributor reviewed the diff and ran the listed validations.