refactor!: Pass the Teams body types by value and rename them to ...Request - #4606
Open
JamBalaya56562 wants to merge 2 commits into
Open
JamBalaya56562 wants to merge 2 commits into
JamBalaya56562 wants to merge 2 commits into
Conversation
…tions.Permission` pointers Updates google#3644
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4606 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 198 198
Lines 18552 18552
=======================================
Hits 18294 18294
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 4, 2026
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #3644
This converts the three
TeamsServicebody types, removing 6 entries from theparamcheckexception lists in.golangci.yml(3 frombody-allowed-pointer-typesand 3 frombody-allowed-wrong-names), plus the 2structfieldallowed-tag-typesentries marked# TODO: Teams.TeamAddTeamMembershipOptionsAddTeamMembershipRequestAddTeamMembershipByID,AddTeamMembershipBySlugTeamAddTeamRepoOptionsAddTeamRepoRequestAddTeamRepoByID,AddTeamRepoBySlugTeamProjectOptionsAddTeamProjectRequestAddTeamProjectByID,AddTeamProjectBySlugThe first commit makes
TeamAddTeamMembershipOptions.RoleandTeamAddTeamRepoOptions.Permission*string, which clears the two# TODO: Teamsentries instructfield'sallowed-tag-types. Both properties are optional in the OpenAPI request schemas (neither schema has arequiredlist), andTeamProjectOptions.Permissionwas already*string.The method names are kept as
Add...: the docs titles are "Add or update ...", andAddalready matches the verb these methods have always used.BREAKING CHANGE:
TeamAddTeamMembershipOptions,TeamAddTeamRepoOptionsandTeamProjectOptionsare renamed toAddTeamMembershipRequest,AddTeamRepoRequestandAddTeamProjectRequest;TeamsService.AddTeamMembershipByID,AddTeamMembershipBySlug,AddTeamRepoByID,AddTeamRepoBySlug,AddTeamProjectByIDandAddTeamProjectBySlugnow take them by value instead of by pointer;AddTeamMembershipRequest.RoleandAddTeamRepoRequest.Permissionare now*string.