Skip to content

Remove duplicated survey downloads during sync - #3889

Open
andreia-ferreira wants to merge 3 commits into
masterfrom
andreia/3867/fix-multiple-calls-sync-loi
Open

Remove duplicated survey downloads during sync#3889
andreia-ferreira wants to merge 3 commits into
masterfrom
andreia/3867/fix-multiple-calls-sync-loi

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

Towards #3867

When the survey data was visible to all participants, the syncLocationsOfInterest method would trigger the download of both user LOIs and shared LOIs. However, in that case, the shared LOIs already contain the user LOI so this was not needed.

Now only one of the two runs: the shared query when visibility is ALL_SURVEY_PARTICIPANTS, the user query otherwise.

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (7dd6f7d) to head (b76c9ab).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3889   +/-   ##
=========================================
  Coverage     68.79%   68.79%           
  Complexity     1929     1929           
=========================================
  Files           412      412           
  Lines         10970    10971    +1     
  Branches       1432     1432           
=========================================
+ Hits           7547     7548    +1     
  Misses         2675     2675           
  Partials        748      748           
Files with missing lines Coverage Δ
...android/repository/LocationOfInterestRepository.kt 65.26% <100.00%> (+0.36%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants