Remove duplicated survey downloads during sync - #3889
Open
andreia-ferreira wants to merge 3 commits into
Open
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
=========================================
Coverage 68.79% 68.79%
Complexity 1929 1929
=========================================
Files 412 412
Lines 10970 10971 +1
Branches 1432 1432
=========================================
+ Hits 7547 7548 +1
Misses 2675 2675
Partials 748 748
🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
Aug 20, 2026
andreia-ferreira
requested a deployment
to
e2e-approval
August 20, 2026 16:27 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3867
When the survey data was visible to all participants, the
syncLocationsOfInterestmethod would trigger the download of both user LOIs and shared LOIs. However, in that case, the shared LOIs already contain the user LOI so this was not needed.Now only one of the two runs: the shared query when visibility is
ALL_SURVEY_PARTICIPANTS, the user query otherwise.@shobhitagarwal1612 PTAL?