Restore testNulls methods to classes that we don't want PackageSanityTest to automatically test with NullPointerTester.#8551
Merged
Conversation
…ityTest` to automatically test with `NullPointerTester`. This lets `PackageSanityTest` see which classes are "manually" tested for nullness—and then disable its automated nullness testing for those. That means that this CL can also allow `PackageSanityTest` run its non-nullness-related testes on those classes. However, those tests are for serialization and for `equals`, so they probably don't matter for the "pure static" classes at stake here. Still, I think that I might like this pattern better for packages where it _could_ matter, as in cl/939798064 for `common.hash`. This CL undoes parts of ec9d2b5. PiperOrigin-RevId: 947204160
copybara-service
Bot
force-pushed
the
test_947136389
branch
from
8ff4a9d to
ae76e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore
testNullsmethods to classes that we don't wantPackageSanityTestto automatically test withNullPointerTester.This lets
PackageSanityTestsee which classes are "manually" tested for nullness—and then disable its automated nullness testing for those.That means that this CL can also allow
PackageSanityTestrun its non-nullness-related testes on those classes. However, those tests are for serialization and forequals, so they probably don't matter for the "pure static" classes at stake here. Still, I think that I might like this pattern better for packages where it could matter, as in cl/939798064 forcommon.hash.This CL undoes parts of ec9d2b5.