Repository navigation
Add Paycall Technologies 055-16 M2M range to Israel metadata - #4086
Open
paycall-apps wants to merge 1 commit into
Open
paycall-apps wants to merge 1 commit into
paycall-apps wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Follow-up to PR google#4063 / issuetracker.google.com/issues/544217149. Release 9.0.37 adopted the BITIT->Paycall Technologies rename for 055-20/21/802/862 but omitted the 055-16 range entirely. * resources/carrier/en/972.txt - Add 9725516|Paycall Technologies (the 055-16XXXXX M2M range allocated to PayCall by the Israeli MoC under the same letter as the 055-20/21 ranges that were already renamed). * resources/PhoneNumberMetadata.xml - Append 5516\d{5} as a new top-level branch of Israel's mobile <nationalNumberPattern>. Without this branch, numbers in the 055-16XXXXX range fail isValidNumber() even though the carrier file lists them. Example valid numbers: 0551612345, 0551699999. Example source: Israeli Ministry of Communications allocation records, same letter that authorized 055-20/21/802/862 (filed as evidence on issuetracker 544217149, 2026-08-09).
paycall-apps
force-pushed
the
paycall-israel-055-16
branch
from
October 8, 2026 19:51
3a2cb81 to
ca5cfee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #4063 / issuetracker.google.com/issues/544217149.
Release 9.0.37 (commit c9d5f73) adopted the BITIT -> Paycall Technologies rename for 055-20 / 055-21 / 055-802 / 055-862 and added the 0105 international prefix, but the 055-16XXXXX range was omitted.
What this PR adds
resources/carrier/en/972.txt — one new record, in numeric order:
972552|019mobile +9725516|Paycall Technologies 9725520|Paycall Technologies 9725521|Paycall Technologiesresources/PhoneNumberMetadata.xml — append one branch to Israel
<mobile><nationalNumberPattern>soisValidNumber("+972551612345")returns true:9[1-9] ) - )\d{5} + )\d{5}| + 5516\d{5} </nationalNumberPattern> </mobile>Why both files
The current pattern on master does not match
5516\d{5}— I decomposed each alternation in the issuetracker comment linked above. Without the<mobile>branch, numbers that this PR adds to the carrier file still fail validation.Scope
+3 / -1), all within the Israel territory.Note on classification
055-16XXXXX is formally an M2M allocation. We placed it in
<mobile>because (a) it is a55Xcellular prefix, (b) libphonenumber has no M2M section, and (c) real end-user handsets dial these numbers and expectisValidNumberto returntrue. If the maintainers prefer a different type (<voip>,<noInternationalDialling>, etc.), please feel free to re-slot — the practical ask is only thatisValidNumber("+972551612345") == trueand that9725516maps to Paycall Technologies in the carrier file.Note on
metadata/metadata.zipThe same gap exists in the CSV-based metadata inside
metadata/metadata.zip.metadata/972/ranges.csvcurrently has rows for552[01],558[06]2, etc. attributed to thepaycalloperator (from the 9.0.37 update), but no row at all for5516— the551Xprefix is unassigned there.operators.csvalready listspaycall ; "0105" ; "Paycall Technologies", so when this PR is adopted into the internal metadata source, the corresponding CSV row (something like5516 ; 9 ; MOBILE ; STANDARD_RATE ; ; false ; "paycall" ; "mobile_2/3/4" ; "IL" ; ; ; GOVERNMENT) should flow through to the nextMetadata updates for releasecommit. We are not touching the zip in this PR per themetadata/README.mdnote that PRs on that directory are not accepted.Validation
ET.parse("resources/PhoneNumberMetadata.xml")succeeds.5516\d{5}is 9 digits (matches Israel's<possibleLengths national="9"/>), consistent with the surrounding alternation.CLA already signed under PR #4063.