Conversation
Resolve the mediapy_test.py conflict in favor of the local fix. Upstream commit b5902b1 relaxes the 10-bit roundtrip threshold by raising factor from 0.8 to 2.5, which absorbs the ffmpeg 8.x gain of 257/256 into a looser RMS bound. The local fix instead measures that gain, asserts it is within 1% of unity, and divides it out, so the residual can still be checked at the original factor of 0.8. The upstream comment about raising the factor no longer applies and is dropped; the comment above the gain computation explains the ffmpeg behavior in its place.
Contributor
Author
|
@Conchylicultor Hi, are you still available to have a look at this? Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurations for pyrefly and ruff to pyproject.toml
Clean up code to remove many existing pyrefly pragma comments, while maintaining compatibility with mypy and pylint.
Update GitHub actions to remove deprecation warnings.
Relax the 10-bit video roundtrip test to ignore a weakness in ffmpeg 8.0.
No change in functionality.