Skip to content

Batch DNS refresh requests on host renames - #3181

Open
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:dnsRefreshBatch
Open

Batch DNS refresh requests on host renames#3181
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:dnsRefreshBatch

Conversation

@gbrodman

@gbrodman gbrodman commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Some hosts can have more than 100k domains linked to them so we probably don't want to insert all those entries at once.

As far as I'm aware this hasn't been an issue in practice, but we should still do it just in case.

Self assessment D.5 number 16


This change is Reviewable

Some hosts can have more than 100k domains linked to them so we probably
don't want to insert all those entries at once.
@gbrodman
gbrodman requested a review from CydeWeys July 29, 2026 19:38

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on gbrodman).


core/src/main/java/google/registry/dns/RefreshDnsOnHostRenameAction.java line 77 at r1 (raw file):

  private void runDnsRefresh() {
    ImmutableSet<VKey<Domain>> linkedDomainKeys =
        tm().transact(

The code gets a decent bit simpler if you don't combine basic error checking in the same transaction as loading all the linked domain keys -- thoughts on doing it that way? Then you shouldn't need this new exception class or special exception handling. And considering how infrequently this is called, having a single additional transaction is a fair trade-off for simpler code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants