Refactor LoadTestAction for usability - #3192
Open
weiminyu wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+322
to
+324
| var _ = | ||
| executorService.submit( | ||
| () -> cloudTasksUtils.enqueue(getQueueName(index % NUM_QUEUES), chunks.get(index))); |
Collaborator
Author
There was a problem hiding this comment.
var _ ... is preferred pattern for suppressing CheckReturnValue rule.
weiminyu
commented
Jul 31, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
Author
There was a problem hiding this comment.
@weiminyu resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
Calculates the delay seconds automatically. This value helps ensure that all EPP requests are enqueued before the scheduled test start time. Since queue insertion is much slower than dispatch, this is essential to maintain a stable QPS rate. Also parallelizes queue insertion using a thread pool. This reduces the delay for enqueuing the requests. BUG=http://b/533414332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculates the delay seconds automatically. This value helps ensure that all EPP requests are enqueued before the scheduled test start time. Since queue insertion is much slower than dispatch, this is essential to maintain a stable QPS rate.
Also parallelizes queue insertion using a thread pool. This reduces the delay for enqueuing the requests.
BUG=http://b/533414332
This change is