Skip to content

chore(deps)!: squash dependency updates#333

Merged
aabmass merged 3 commits into
google:mainfrom
aabmass:squash-deps
Jun 30, 2026
Merged

chore(deps)!: squash dependency updates#333
aabmass merged 3 commits into
google:mainfrom
aabmass:squash-deps

Conversation

@aabmass

@aabmass aabmass commented Jun 26, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: Node.js 14 and 16 are no longer supported.

Squashed Renovate PRs:

Excluded:

Dropping Support:

  • Node.js 14 and 16 are no longer supported because of upstream dependency requirements. The CI workflow is updated to test on Node 18, 20, and 22.

Fixes:

  • Fix JIT inlining issues on Node 22 by wrapping setTimeout callbacks in named functions (busyLoopTick) so V8 attributes samples to our own script instead of (anonymous) or node:internal/timers.
  • Update line number regex in system tests to make it robust to JIT compiler line-attributions.
  • Fixes Node 21+ support - system test failing #283

@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.58%. Comparing base (dead429) to head (82a5268).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   41.92%   38.58%   -3.34%     
==========================================
  Files          14       14              
  Lines        2092     2340     +248     
  Branches       42       42              
==========================================
+ Hits          877      903      +26     
- Misses       1197     1419     +222     
  Partials       18       18              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aabmass aabmass marked this pull request as draft June 26, 2026 20:15
@aabmass

aabmass commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

I'm going to remove mapbox dep first.

@aabmass aabmass force-pushed the squash-deps branch 4 times, most recently from 5f83f4a to e0deab9 Compare June 30, 2026 02:58
Comment thread system-test/busybench/src/busybench.ts
@aabmass aabmass changed the title chore(deps): squash dependency updates chore(deps)!: squash dependency updates Jun 30, 2026
@aabmass aabmass marked this pull request as ready for review June 30, 2026 17:03
@aabmass aabmass requested a review from psx95 June 30, 2026 17:03
Comment thread package.json Outdated
Comment thread system_test_failure2.log Outdated
Comment thread js-green-licenses.json

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowlist configurations in js-green-licenses.json were added because the tool flags valid, permissive licenses like BlueOak-1.0.0 (used by minipass) as failures due to its hardcoded default list. These are existing transitive dev dependencies (e.g., from glob), not new ones.

@aabmass aabmass force-pushed the squash-deps branch 2 times, most recently from d504d39 to d1d0032 Compare June 30, 2026 18:43
@aabmass aabmass linked an issue Jun 30, 2026 that may be closed by this pull request
aabmass added a commit to aabmass/pprof-nodejs that referenced this pull request Jun 30, 2026
PR google#333 claimed to squash and merge several devDependency upgrades from Renovate, but only updated package-lock.json without modifying package.json. This commit updates package.json to match those intended versions:

- @types/pretty-ms to ^5.0.0 (google#289)
- @types/sinon to ^21.0.0 (google#322)
- linkinator to ^7.0.0 (google#318)
- mocha to ^11.0.0 (google#319)
- protobufjs-cli to 1.3.2 (google#330)
- tmp to 0.2.6 (google#332)
- Bump protobufjs from ~7.4.0 to ~7.6.4 to address critical prototype pollution and DoS advisories
- Regenerate proto/profile.js and proto/profile.d.ts with updated pbjs/pbts compiler
aabmass added 3 commits June 30, 2026 20:43
BREAKING CHANGE: Node.js 14 and 16 are no longer supported.
Squashed Renovate PRs:
- google#332 (tmp to v0.2.6)
- google#330 (protobufjs-cli to v1.3.2)
- google#328 (protobufjs to ~7.6.0)
- google#325/google#317 (debian docker tag to 12)
- google#323 (@mapbox/node-pre-gyp to v2)
- google#322 (@types/sinon to v21)
- google#319 (mocha to v11)
- google#318 (linkinator to v7)
- google#316 (golang docker tag to 1.24)
- google#289 (@types/pretty-ms to v5)

Excluded:
- google#326 (p-limit to v7) because versions >= 4.0.0 are ESM-only.

TAG=agy
CONV=4ca117e0-d8fa-4e4c-8cfa-b52e896710d3
PR google#333 claimed to squash and merge several devDependency upgrades from Renovate, but only updated package-lock.json without modifying package.json. This commit updates package.json to match those intended versions:

- @types/pretty-ms to ^5.0.0 (google#289)
- @types/sinon to ^21.0.0 (google#322)
- linkinator to ^7.0.0 (google#318)
- mocha to ^11.0.0 (google#319)
- protobufjs-cli to 1.3.2 (google#330)
- tmp to 0.2.6 (google#332)
- Bump protobufjs from ~7.4.0 to ~7.6.4 to address critical prototype pollution and DoS advisories
- Regenerate proto/profile.js and proto/profile.d.ts with updated pbjs/pbts compiler
@aabmass aabmass merged commit 342c047 into google:main Jun 30, 2026
12 checks passed
@aabmass aabmass deleted the squash-deps branch June 30, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node 21+ support - system test failing

3 participants