Skip to content

Fix clean handling for missing outputs - #1473

Draft
hugosmoreira wants to merge 1 commit into
google:mainfrom
hugosmoreira:fix/clean-missing-output
Draft

Fix clean handling for missing outputs#1473
hugosmoreira wants to merge 1 commit into
google:mainfrom
hugosmoreira:fix/clean-missing-output

Conversation

@hugosmoreira

Copy link
Copy Markdown

Summary

  • check the previous output manifest before an if-file-deleted incremental run
  • clean when outputs have changed so incremental tools cannot cache an incomplete result
  • propagate manifest errors and document the expanded clean behavior
  • add a regression covering a missing output with surviving incremental state

Fixes #1471

Validation

  • npm run build
  • focused regression test (including a failing negative control before the fix)
  • Prettier check on changed files
  • ESLint on changed TypeScript files
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clean: "if-file-deleted" can permanently cache incomplete output when the build tool is incremental

1 participant