Skip to content

[derive] Allow missing_debug_implementations on KnownLayout helpers - #3568

Draft
apasel422 wants to merge 1 commit into
google:mainfrom
apasel422:fix-knownlayout-derive
Draft

[derive] Allow missing_debug_implementations on KnownLayout helpers#3568
apasel422 wants to merge 1 commit into
google:mainfrom
apasel422:fix-knownlayout-derive

Conversation

@apasel422

Copy link
Copy Markdown

Add #[allow(missing_debug_implementations)] to __ZerocopyKnownLayoutMaybeUninit and the generated field handle structs to prevent compile errors when the derive target is inside a macro and the crate has #[deny(missing_debug_implementations)].

Fixes #3567

@codecov-commenter

codecov-commenter commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (286dd29) to head (494fa65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3568   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apasel422
apasel422 force-pushed the fix-knownlayout-derive branch 2 times, most recently from ee3ec61 to e01abd2 Compare August 24, 2026 20:17
@apasel422
apasel422 marked this pull request as ready for review August 24, 2026 20:23
Add `#[allow(missing_debug_implementations)]` to `__ZerocopyKnownLayoutMaybeUninit`
and the generated field handle structs to prevent compile errors when the derive target
is inside a macro and the crate has `#[deny(missing_debug_implementations)]`.
@apasel422
apasel422 force-pushed the fix-knownlayout-derive branch from e01abd2 to 494fa65 Compare August 24, 2026 20:40
@apasel422

Copy link
Copy Markdown
Author

It looks like there's a separate issue blocking this from building, related to field visibility vs struct visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KnownLayout derive breaks with deny(missing_debug_implementations)

2 participants