[ci] Freeze the current CI coverage baseline - #3573
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m #3573 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d61725c to
85273d3
Compare
4c0e80d to
cf9c091
Compare
cf9c091 to
8bb2cbc
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat any earlier review as stale if it targets |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
*Authored by Codex, posting via joshlf's account* Record the exact matrix cells and standalone operations present at 286dd29. Also record normalized obligations so repeated work remains visible when the new planner begins grouping runner work. Derive matrix sets using generic Actions expansion and a separate hand-written policy model. They agree on all 60 PR build cells, 182 full build cells, 0 PR Miri cells, and 64 full Miri cells. Keep representative argument lists as an independent check on command construction. These files are reviewed evidence, not a runtime Actions interpreter or a self-generated planner expectation. Tests: source hashes; TSV shape, sort, and count checks; JSON parsing; independent set comparison. gherrit-pr-id: G2no4jjfqasubxit6mn7xvdcyd3ko5ji3
8bb2cbc to
3c0385b
Compare
4f893f6 to
1ae23ca
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c0385b18e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The normalized target for `cargo-doc` is empty because the workflow does not | ||
| pass `--target` to that command. Consequently, the fixture exposes 22 doc | ||
| obligations that run between two and eleven times per event. It also exposes the | ||
| eight check scripts run both by their standalone jobs and by `run-git-hooks`. |
There was a problem hiding this comment.
The logical fixture actually contains 26 cargo-doc rows (logical-obligations.tsv lines 324–349), not 22. Only 22 of those rows are repeated between two and eleven times; the four aarch64-version-specific rows execute once on full events and zero times on PRs. As written, this baseline documentation understates the frozen coverage and obscures which count the subsequent statement about 30 repeated rows is using.
Useful? React with 👍 / 👎.
| required-check-aggregate 1 1 always all-jobs-succeed/Require every dependency to succeed | ||
| required-check-cancellation 1 1 always all-jobs-succeed/Reject workflow cancellation |
There was a problem hiding this comment.
In the source workflow's all-jobs-succeed job, Reject workflow cancellation is eligible only under if: cancelled(), while Require every dependency to succeed has the default success() condition and is skipped after the cancellation step exits 1. Recording both as always loses the fail-closed control flow that this fixture is intended to freeze, so a later planner comparison could accept running the aggregate during cancellation or omitting the cancellation-only guard.
Useful? React with 👍 / 👎.
| codegen-clippy pull_request,full codegen Clippy zerocopy direct ["./cargo.sh","+nightly","clippy","--locked","--package","zerocopy","--target","x86_64-unknown-linux-gnu","--all-features","--test","codegen","--verbose","--","-Dwarnings"] | ||
| codegen-test pull_request,full codegen Run tests zerocopy direct ["./cargo.sh","+nightly","test","--locked","--package","zerocopy","--target","x86_64-unknown-linux-gnu","--all-features","--verbose","--test","codegen"] | ||
| coverage-generate pull_request,full coverage Generate code coverage zerocopy direct ["./cargo.sh","+nightly","llvm-cov","--package","zerocopy","--target","x86_64-unknown-linux-gnu","--all-features","--doctests","--lcov","--output-path","lcov.info","--verbose"] | ||
| coverage-upload pull_request,full coverage Upload coverage to Codecov zerocopy action codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f |
There was a problem hiding this comment.
The coverage job's working-directory: zerocopy default applies only to run steps, not to this uses: codecov/codecov-action step, so the action executes from the workspace root; the workflow's files: zerocopy/lcov.info input also relies on that root-relative context. Freezing its working directory as zerocopy can make a planner reproduce the action with paths resolved as though it ran under zerocopy/, potentially looking for zerocopy/zerocopy/lcov.info instead.
Useful? React with 👍 / 👎.
2 participants
Authored by Codex, posting via joshlf's account
Record the exact matrix cells and standalone operations present at
286dd29. Also record normalized obligations so repeated work remains
visible when the new planner begins grouping runner work.
Derive matrix sets using generic Actions expansion and a separate
hand-written policy model. They agree on all 60 PR build cells, 182 full
build cells, 0 PR Miri cells, and 64 full Miri cells.
Keep representative argument lists as an independent check on command
construction. These files are reviewed evidence, not a runtime Actions
interpreter or a self-generated planner expectation.
Tests: source hashes; TSV shape, sort, and count checks; JSON parsing;
independent set comparison.
Latest Update: v4 — Compare vs v3
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G2no4jjfqasubxit6mn7xvdcyd3ko5ji3 && git checkout -b pr-G2no4jjfqasubxit6mn7xvdcyd3ko5ji3 FETCH_HEADCheckout
git fetch origin refs/heads/G2no4jjfqasubxit6mn7xvdcyd3ko5ji3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G2no4jjfqasubxit6mn7xvdcyd3ko5ji3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.