Skip to content

Remove developer token from docs and examples - #922

Merged
AnashOommen merged 1 commit into
googleads:mainfrom
pattersonlois:remove-dev-token-docs
Oct 23, 2026
Merged

AnashOommen merged 1 commit into
googleads:mainfrom
pattersonlois:remove-dev-token-docs

Conversation

@pattersonlois

Copy link
Copy Markdown
Contributor

Following the September 9, 2026 sunset of Google Ads API developer tokens, remove user-facing developer token instructions and placeholders from sample configurations and code examples:

  • Remove setDeveloperToken and api.googleads.developerToken from ads.properties.sample.
  • Remove DEVELOPER_TOKEN and .setDeveloperToken() from ConfigureClientLibraryProgrammatically.java.
  • Stop populating api.googleads.developerToken in GenerateUserCredentials.java.
  • Update rate limit comment in ParallelReportDownload.java to reference the Google Cloud project level.

Following the September 9, 2026 sunset of Google Ads API developer tokens, remove user-facing developer token instructions and placeholders from sample configurations and code examples:

- Remove `setDeveloperToken` and `api.googleads.developerToken` from `ads.properties.sample`.
- Remove `DEVELOPER_TOKEN` and `.setDeveloperToken()` from `ConfigureClientLibraryProgrammatically.java`.
- Stop populating `api.googleads.developerToken` in `GenerateUserCredentials.java`.
- Update rate limit comment in `ParallelReportDownload.java` to reference the Google Cloud project level.
@jradcliff jradcliff added the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Oct 22, 2026
@kokoro-team kokoro-team removed the kokoro:run This label is required to run a kokoro presubmit if an external contributor sends a PR. label Oct 22, 2026

@jradcliff jradcliff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the getters and setters in ./google-ads/src/main/java/com/google/ads/googleads/lib/GoogleAdsHeaderProvider.java, along with any references to those?

@pattersonlois

Copy link
Copy Markdown
Contributor Author

@jradcliff Before I update the PR, could you clarify the intended scope for GoogleAdsClient?

  1. If we remove getDeveloperToken() and Builder.setDeveloperToken(String) from GoogleAdsHeaderProvider and remove .setDeveloperToken(getDeveloperToken()) from GoogleAdsClient.Builder.getHeaders(), should we keep (or mark @Deprecated) getDeveloperToken() / setDeveloperToken(String) on GoogleAdsClient and GoogleAdsClient.Builder for backward compatibility, or remove those from GoogleAdsClient as well?
  2. Note that since GoogleAdsHeaderProvider (and GoogleAdsClient) are public, removing the public getters/setters from either class is a breaking signature change. Is a breaking change expected here?

@jradcliff

Copy link
Copy Markdown
Member

@jradcliff Before I update the PR, could you clarify the intended scope for GoogleAdsClient?

  1. If we remove getDeveloperToken() and Builder.setDeveloperToken(String) from GoogleAdsHeaderProvider and remove .setDeveloperToken(getDeveloperToken()) from GoogleAdsClient.Builder.getHeaders(), should we keep (or mark @Deprecated) getDeveloperToken() / setDeveloperToken(String) on GoogleAdsClient and GoogleAdsClient.Builder for backward compatibility, or remove those from GoogleAdsClient as well?
  2. Note that since GoogleAdsHeaderProvider (and GoogleAdsClient) are public, removing the public getters/setters from either class is a breaking signature change. Is a breaking change expected here?

@pattersonlois , I'll approve this PR since we definitely want the changes you've already made. We can follow up with a separate PR on the slightly more complicated question of what to do with GoogleAdsClient and GoogleAdsHeader.

@AnashOommen
AnashOommen merged commit 61a6551 into googleads:main Oct 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants