Repository navigation
Update CODEOWNERS - #1098
Update CODEOWNERS#1098AnashOommen wants to merge 1 commit into
Conversation
| @@ -1 +1,2 @@ | |||
| * @googleads/google-ads-python-codereview | |||
| @googleads/google-ads-python-codereview | |||
There was a problem hiding this comment.
Bug: this line no longer has a file pattern, so it owns nothing.
CODEOWNERS syntax is <pattern> <owner> [<owner>...]. Dropping the leading * makes GitHub parse @googleads/google-ads-python-codereview as the pattern (a path literally named that) with zero owners. GitHub considers "pattern with no owners" valid syntax (it's how you un-own a subpath), which is why GET /repos/googleads/google-ads-python/codeowners/errors?ref=Fix-codeowners (and the same for the sibling google-ads-ruby#567 and google-ads-dotnet#672) returns {"errors": []} — but the effect is that no file in the repo has a code owner.
Consequences on main, which has require_code_owner_reviews: true:
- Reviewer auto-assignment for both teams stops.
- The "require review from Code Owners" branch-protection check becomes vacuously satisfied on every PR (no owner matches → no owner review required), so the gate is silently removed.
Suggested fix (single line, both teams):
| @googleads/google-ads-python-codereview | |
| * @googleads/google-ads-python-codereview @googleads/googleads-release-rotation |
FYI the same change was merged in google-ads-java#920 earlier today with the same shape; it's worth a follow-up fix there too.
| @@ -1 +1,2 @@ | |||
| * @googleads/google-ads-python-codereview | |||
| @googleads/google-ads-python-codereview | |||
| @googleads/googleads-release-rotation | |||
There was a problem hiding this comment.
Even once the * pattern is restored, don't split the two teams across two * lines. CODEOWNERS uses last-match-wins per path, so
* @googleads/google-ads-python-codereview
* @googleads/googleads-release-rotation
would make only googleads-release-rotation the owner. Put both owners on the one * line (see suggestion on line 1) and delete this line.
| @googleads/googleads-release-rotation |
No description provided.