[alexoneill]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces support for mutateRows (bulk mutations) across the Bigtable client's async API and compatibility layers, including TableAsync, AuthorizedViewAsync, and TableBase, along with a new MutateRowsShim implementation. The review feedback suggests importing com.google.common.base.Preconditions and adding a defensive null check for the client parameter in the MutateRowsShim constructor to ensure object integrity.

[mutianf]

We're returning RateLimitInfo in SessionMutateRowsResponse, but nothing checks / uses it in the session client path?

[mutianf]

Hmm, I think this only reports RPC level status? if there are entry level failures it'll get silently dropped?

[alexoneill]

Good catch — fixed in 7633592:

1. Added MutateRowsRetryingVRpc in internal.middleware (wired in TableBase.mutateRows) to handle partial entry-level retries on the session path: transient entry errors (DEADLINE_EXCEEDED, UNAVAILABLE) are retried only for idempotent entries while locking in prior OK / permanent entry outcomes and remapping indices back to 0..N-1 (plus recording missing response indices as permanent INTERNAL errors).
2. Updated MutateRowsShim / Shim.decorateMutateRows to return MutateRowsAttemptResult (and translate whole-vRPC failures into MutateRowsException, preserved intact by DivertingUnaryCallable.translateException), and moved sessionShim.decorateMutateRows into EnhancedBigtableStub.createMutateRowsBaseCallable() so both bulkMutateRows and Batcher (newMutateRowsBatcher) have full entry-error parity with the classic path.

[mutianf]

full copy of every mutation to compute one boolean

Util.isIdempotent short-circuits, but toImmutableList() materializes everything first — up to BulkMutation.MAX_MUTATION (100k) references per call on the hot path. Use flatMap(...).allMatch(...) or a nested loop with early return.

[alexoneill]

Fixed in 7633592 — replaced the toImmutableList() copy with short-circuiting req.getEntriesList().stream().allMatch(entry -> Util.isIdempotent(entry.getMutationsList())).

[alexoneill]

@mutianf Addressed SessionMutateRowsResponse.RateLimitInfo on the session path in 7633592:

• Propagated isServerInitiatedFlowControlEnabled into ClientSettings / Client and ShimImpl.create so FeatureFlags sets mutate_rows_rate_limit = true and mutate_rows_rate_limit2 = true when batch write flow control is enabled.
• Added non-blocking SessionMutateRowsRateLimiter + RateLimitingVRpc middleware scheduled on BigtableTimer (matching ConditionalRateLimiter / RateLimitingServerStreamingCallable parameters: default 10 QPS starting disabled, 1s smooth-bursty window, QPS bounds [0.1, 100_000], factor bounds [0.7, 1.3], period-gated updates/disabling, 0.7x / 10s backoff on DEADLINE_EXCEEDED/UNAVAILABLE/RESOURCE_EXHAUSTED, and failing fast with DEADLINE_EXCEEDED without consuming a permit when the wait exceeds remaining deadline).
• Wired CSM metrics (batchWriteFlowControlTargetQps and batchWriteFlowControlFactor) through VRpcTracer / VRpcTracerImpl / CompositeVRpcTracer.