Skip to content

feat(storage): add StorageMetricsContext for operation metrics state #14728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nidhiii-27 wants to merge 8 commits into
base: feat/storage-metrics-context-error-mapping
Choose a base branch
from
+1,024 −2
Open

feat(storage): add StorageMetricsContext for operation metrics state #14728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
edb3def
feat(storage): add StorageMetricsContext for operation metrics state …
nidhiii-27 Oct 22, 2026
900248a
refactor(storage): address PR #14728 review comments on StorageMetric…
nidhiii-27 Oct 22, 2026
519a319
Merge branch 'feat/storage-metrics-context-error-mapping' into feat/s…
nidhiii-27 Oct 22, 2026
4728da2
feat(storage): add attempt recording methods to StorageMetricsContext…
nidhiii-27 Oct 22, 2026
74d10a6
fix(storage): gate status code extraction on rpcSystemName in attempt…
nidhiii-27 Oct 22, 2026
198a662
test(storage): consolidate StorageMetricsContextTest and remove unuse…
nidhiii-27 Oct 22, 2026
1be4eba
feat(storage): string-type HTTP response status code and set empty st…
nidhiii-27 Oct 22, 2026
011fdca
Merge branch 'feat/storage-metrics-context-error-mapping' into feat/s…
nidhiii-27 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...age/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClientMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ final class StorageClientMetrics {
AttributeKey.stringKey("rpc.response.status_code");
static final AttributeKey<String> KEY_HTTP_REQUEST_METHOD =
AttributeKey.stringKey("http.request.method");
static final AttributeKey<Long> KEY_HTTP_RESPONSE_STATUS_CODE =
AttributeKey.longKey("http.response.status_code");
static final AttributeKey<String> KEY_HTTP_RESPONSE_STATUS_CODE =
AttributeKey.stringKey("http.response.status_code");
static final AttributeKey<String> KEY_URL_TEMPLATE = AttributeKey.stringKey("url.template");
static final AttributeKey<String> KEY_SERVER_ADDRESS = AttributeKey.stringKey("server.address");
static final AttributeKey<Long> KEY_SERVER_PORT = AttributeKey.longKey("server.port");
Expand Down
Loading
Loading