Skip to content

chore(kokoro): Fetch latest enabled secret instead of disabled latest version #14730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sakthivelmanii wants to merge 4 commits into from
Closed

chore(kokoro): Fetch latest enabled secret instead of disabled latest version #14730

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31eb7a8
chore(kokoro): Fetch latest enabled secret instead of disabled latest…
sakthivelmanii Oct 22, 2026
5438aad
Addressed comments
sakthivelmanii Oct 22, 2026
7164a48
Addressed comments
sakthivelmanii Oct 22, 2026
af0f7d9
Addressed comments
sakthivelmanii Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions .kokoro/populate-secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,27 @@ mkdir -p ${SECRET_LOCATION}
for key in $(echo ${SECRET_MANAGER_KEYS} | sed "s/,/ /g")
do
msg "Retrieving secret ${key}"
docker run --entrypoint=gcloud \
--volume=${KOKORO_GFILE_DIR}:${KOKORO_GFILE_DIR} \
VERSION=$(docker run --rm --entrypoint=gcloud \
--volume="${KOKORO_GFILE_DIR}:${KOKORO_GFILE_DIR}" \
gcr.io/google.com/cloudsdktool/cloud-sdk \
secrets versions access latest \
secrets versions list "${key}" \
--project cloud-devrel-kokoro-resources \
--secret ${key} > \
--filter="state=enabled" \
--sort-by="~createTime" \
--limit=1 \
--format="value(name.basename())") || VERSION=""
Comment thread
sakthivelmanii marked this conversation as resolved.

if [ -z "${VERSION}" ]; then
msg "Error retrieving enabled version for secret ${key}"
exit 1
fi

docker run --rm --entrypoint=gcloud \
--volume="${KOKORO_GFILE_DIR}:${KOKORO_GFILE_DIR}" \
gcr.io/google.com/cloudsdktool/cloud-sdk \
secrets versions access "${VERSION}" \
--project cloud-devrel-kokoro-resources \
--secret "${key}" > \
"${SECRET_LOCATION}/${key}"
Comment thread
sakthivelmanii marked this conversation as resolved.
Comment on lines +46 to 52

@gemini-code-assist gemini-code-assist Bot Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the docker run command to access the secret payload fails, the script currently does not exit explicitly (unless set -e is active). To prevent silent failures or continuing with empty/corrupted secret files, we should explicitly handle the failure of this command and exit with an error.

Suggested change
docker run --rm --entrypoint=gcloud \
--volume="${KOKORO_GFILE_DIR}:${KOKORO_GFILE_DIR}" \
gcr.io/google.com/cloudsdktool/cloud-sdk \
secrets versions access "${VERSION}" \
--project cloud-devrel-kokoro-resources \
--secret "${key}" > \
"${SECRET_LOCATION}/${key}"
docker run --rm --entrypoint=gcloud \
--volume="${KOKORO_GFILE_DIR}:${KOKORO_GFILE_DIR}" \
gcr.io/google.com/cloudsdktool/cloud-sdk \
secrets versions access "${VERSION}" \
--project cloud-devrel-kokoro-resources \
--secret "${key}" > \
"${SECRET_LOCATION}/${key}" || { msg "Error retrieving secret payload for ${key}"; exit 1; }

if [[ $? == 0 ]]; then
msg "Secret written to ${SECRET_LOCATION}/${key}"
Expand Down
Loading