Repository navigation
chore(bigquery-jdbc): remove duplicate classes from ITNightlyTests suite - #14757
Open
keshavdandeva wants to merge 2 commits into
Open
keshavdandeva wants to merge 2 commits into
keshavdandeva wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the nightly integration test configuration. In jdbc-nightly.sh, it configures the integration tests to run both ITPresubmitTests and ITNightlyTests. In ITNightlyTests.java, it removes several test classes that are already covered by ITPresubmitTests to avoid duplication, and adds a Javadoc comment explaining this change. There are no review comments to address.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ITAuthTests,ITBigQueryJDBCTest,ITJdbcTimestampPicosTestandITPcntTestare in bothITPresubmitTestsandITNightlyTests. Kokorobq_drivers_v2runs both suites together,so these classes run twice in parallel and write report files with the same name. The last one
to finish overwrites the other: in Kokoro integration #112 and proxy #111,
build.logshows atest failure but the published test results show none.
Changes
ITNightlyTests: keep onlyITNightlyBigQueryTestandITOpenTelemetryTest..cloudbuild/scripts/jdbc-nightly.sh: runITPresubmitTests,ITNightlyTestsso the Cloud Buildnightly still runs the 4 classes removed from
ITNightlyTests.Effect
bq_drivers_v2: no config change; each class runs once and is reported once.ITPresubmitTests): unchanged.