Repository navigation
chore(bigquery-jdbc): use BQ SDK defaults for HttpTransportOptions - #14760
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates BigQueryJdbcProxyUtility.java to initialize the HttpTransportOptions builder using BigQueryOptions.getDefaultHttpTransportOptions().toBuilder(). Feedback indicates that this change is redundant and inefficient, as it unnecessarily creates intermediate objects compared to using HttpTransportOptions.newBuilder() directly.
keshavdandeva
approved these changes
Oct 26, 2026
keshavdandeva
left a comment
keshavdandeva
left a comment
Contributor
There was a problem hiding this comment.
We should also update the documentation default value for timeout, I think right now it says 0
Neenu1995
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update JDBC driver to use defaults matching SDK defaults for HttpTransportOptions