Repository navigation
fix(storage): handle write_handle-only responses while awaiting flush ack in BidiUploadState - #14775
Draft
nidhiii-27 wants to merge 1 commit into
Draft
nidhiii-27 wants to merge 1 commit into
nidhiii-27 wants to merge 1 commit into
Conversation
… ack in BidiUploadState Allow AppendableUploadState.onResponse to update writeHandle and return early when an intermediate BidiWriteObjectResponse carries only write_handle without persisted_size or resource, preventing IllegalStateException during flush/awaitAck. [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AppendableUploadState in BidiUploadState.java to return null when a response contains a write handle but lacks a persisted size or resource, provided the state is not in a takeover phase. It also adds corresponding unit tests in BidiUploadTest.java to verify this behavior, including handling intermediate write handles during flushes. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow AppendableUploadState.onResponse to update writeHandle and return early when an intermediate BidiWriteObjectResponse carries only write_handle without persisted_size or resource, preventing IllegalStateException during flush/awaitAck.
[Generated-by: AI]