Skip to content

fix(bigquery-jdbc): fix naive fallback of parameter count - #14779

Open
Neenu1995 wants to merge 5 commits into
mainfrom
fix-no-parameter
Open

Neenu1995 wants to merge 5 commits into
mainfrom
fix-no-parameter

Conversation

@Neenu1995

@Neenu1995 Neenu1995 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

b/577457020

@Neenu1995
Neenu1995 requested review from a team as code owners October 26, 2026 19:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates BigQueryPreparedStatement to return 0 when queryStatistics is present but contains no query parameters, and adds an integration test to verify this behavior for queries with string literals containing '?'. The feedback suggests simplifying the conditional checks on queryStatistics to avoid redundant null checks and improve readability.

Neenu1995 and others added 4 commits October 26, 2026 17:51
…c/BigQueryPreparedStatement.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants