Skip to content

chore(kokoro): fix missing flakybot and codecov scripts - #14792

Open
sakthivelmanii wants to merge 1 commit into
mainfrom
chore-kokoro-java8
Open

sakthivelmanii wants to merge 1 commit into
mainfrom
chore-kokoro-java8

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Remove flakybot and codecov execution from the Kokoro build script. These tools have been deprecated and their corresponding gfile resources are no longer provided. This was causing No such file or directory errors during the shared install phase of the Kokoro build. Removing these sections allows the build to complete successfully.

@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner October 27, 2026 18:43
@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) October 27, 2026 18:43
@sakthivelmanii

Copy link
Copy Markdown
Contributor Author

/gemini review

@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner October 27, 2026 18:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors lazy initialization in AbstractLazyInitializer to allow subclasses to control whether initialization errors are cached. Specifically, DatabaseClientImpl and MultiplexedSessionDatabaseClient are updated to avoid caching transient, retryable errors (such as deadline exceeded, resource exhausted, or unavailable) during dialect detection, allowing subsequent attempts to retry. Feedback suggests also avoiding the caching of interrupted or cancelled exceptions (e.g., InterruptedException or ErrorCode.CANCELLED) to prevent the long-lived DatabaseClient from being permanently poisoned by these transient events.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates AbstractLazyInitializer to support conditional caching of initialization errors, allowing transient or retryable errors to be retried on subsequent calls instead of being permanently cached. This mechanism is applied to dialect detection in MultiplexedSessionDatabaseClient and DatabaseClientImpl to recover from transient Spanner errors. The review feedback suggests extending this logic to explicitly avoid caching InterruptedException and ErrorCode.CANCELLED errors, as these are transient, thread-specific conditions that should not permanently break the database client.

Remove flakybot and codecov execution from Kokoro build script. These tools have been deprecated and their corresponding gfile resources are no longer provided, leading to 'No such file or directory' errors during shared install.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant