Repository navigation
chore(kokoro): fix missing flakybot and codecov scripts - #14792
sakthivelmanii wants to merge 1 commit into
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors lazy initialization in AbstractLazyInitializer to allow subclasses to control whether initialization errors are cached. Specifically, DatabaseClientImpl and MultiplexedSessionDatabaseClient are updated to avoid caching transient, retryable errors (such as deadline exceeded, resource exhausted, or unavailable) during dialect detection, allowing subsequent attempts to retry. Feedback suggests also avoiding the caching of interrupted or cancelled exceptions (e.g., InterruptedException or ErrorCode.CANCELLED) to prevent the long-lived DatabaseClient from being permanently poisoned by these transient events.
There was a problem hiding this comment.
Code Review
This pull request updates AbstractLazyInitializer to support conditional caching of initialization errors, allowing transient or retryable errors to be retried on subsequent calls instead of being permanently cached. This mechanism is applied to dialect detection in MultiplexedSessionDatabaseClient and DatabaseClientImpl to recover from transient Spanner errors. The review feedback suggests extending this logic to explicitly avoid caching InterruptedException and ErrorCode.CANCELLED errors, as these are transient, thread-specific conditions that should not permanently break the database client.
Remove flakybot and codecov execution from Kokoro build script. These tools have been deprecated and their corresponding gfile resources are no longer provided, leading to 'No such file or directory' errors during shared install.
5bd45e3 to
35c0d89
Compare
Remove
flakybotandcodecovexecution from the Kokoro build script. These tools have been deprecated and their corresponding gfile resources are no longer provided. This was causingNo such file or directoryerrors during the shared install phase of the Kokoro build. Removing these sections allows the build to complete successfully.