Repository navigation
fix(bigtable): check isOk and getRejected first in RetryingVRpc.shouldRetry - #14795
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the retry logic in RetryingVRpc to short-circuit successful RPCs and immediately prevent retries for results explicitly rejected by the client, even if they contain RetryInfo. Additionally, a new unit test has been added to verify this behavior. There are no review comments, and the changes look solid, so I have no further feedback to provide.
mutianf
approved these changes
Oct 27, 2026
igorbernstein2
enabled auto-merge (squash)
October 27, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
isOk()andgetRejected()checks to the top ofRetryingVRpc.Active.shouldRetryso successful RPCs short-circuit immediately and client-rejected results are never retried even ifRetryInfois present.