Repository navigation
fix(bigtable): avoid mutating Query in-place in createPointReadCallable - #14797
Open
igorbernstein2 wants to merge 2 commits into
Open
igorbernstein2 wants to merge 2 commits into
igorbernstein2 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies EnhancedBigtableStub to prevent mutating the original Query object when performing a point read. Instead of calling query.limit(1), the code now converts the query to a proto builder and sets the row limit on the proto representation directly. A corresponding unit test has been added to verify that reusing the query object does not carry over the single-row limit. There are no review comments to address, and the changes look solid.
mutianf
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
rows_limit = 1on the builtReadRowsRequestproto instead of callingquery.limit(1)inEnhancedBigtableStub.createPointReadCallable, preventing in-place mutation of the caller'sQueryinstance when a point read or single-keyreadRowsexecutes on the classic path.