Repository navigation
fix(bigtable): pass cell value size to RowBuilder.startCell in RowBuilderShim - #14800
Open
igorbernstein2 wants to merge 1 commit into
Open
igorbernstein2 wants to merge 1 commit into
igorbernstein2 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates RowBuilderShim to pass the actual cell value size (cell.getValue().size()) instead of 0 when calling startCell during row building from a proto. It also adds clarifying Javadoc to the RowBuilder.startCell interface method explaining this behavior, and introduces a new unit test to verify that the correct cell value size is passed. I have no feedback to provide on these changes.
mutianf
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
cell.getValue().size()instead of0toRowBuilder.startCellinRowBuilderShim.buildRowFromProto, matchingStateMachineandDefaultRowAdapter.createRowFromProto, and clarify thesizeparameter semantics inRowAdapter.RowBuilder#startCellJavadoc.