Skip to content

docs(bigtable): document that skipped large rows count towards row limit #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorbernstein2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(bigtable): document that skipped large rows count towards row limit #14801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...java/com/google/cloud/bigtable/data/v2/stub/readrows/LargeReadRowsResumptionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class LargeReadRowsResumptionStrategy<RowT>
Logger.getLogger(LargeReadRowsResumptionStrategy.class.getName());
private final RowAdapter<RowT> rowAdapter;
private ByteString lastSuccessKey = ByteString.EMPTY;
// Number of rows processed excluding Marker row.
// Number of rows processed (including skipped large rows, excluding marker rows).
private long numProcessed;
private ByteString largeRowKey = ByteString.EMPTY;
// we modify the original request in the resumption strategy regardless of how many times it has
Expand Down Expand Up @@ -93,6 +93,8 @@ public Throwable processError(Throwable throwable) {
if (rowKeyExtracted != null) {
LOGGER.warning("skipping large row " + rowKeyExtracted);
this.largeRowKey = rowKeyExtracted;
// Skipped large rows would have been returned if not for system size limits, so they
// intentionally count towards the query's row limit.
numProcessed = numProcessed + 1;
}
return throwable;
Expand All @@ -116,7 +118,7 @@ private ByteString extractLargeRowKey(Throwable t) {
* <p>This returns an updated request excluding all the rows keys & ranges till (including) {@link
* #lastSuccessKey} & also excludes the last encountered large row key ({@link #largeRowKey}).
* Also, this implementation takes care to update the row limit of the request to account for all
* of the received rows.
* of the received rows and skipped large rows.
*/
@Override
public ReadRowsRequest getResumeRequest(ReadRowsRequest originalRequest) {
Expand Down
Loading