chore: example changes from Release Please files by Librarian#8777
Draft
suztomo wants to merge 1 commit into
Draft
chore: example changes from Release Please files by Librarian#8777suztomo wants to merge 1 commit into
suztomo wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes and alphabetizes package definitions across release configuration files, adds the new library google-cloud-agentregistry, and removes unused mixins configurations from several libraries in librarian.yaml. Feedback is provided regarding the missing version field for the newly added google-cloud-agentregistry library in librarian.yaml to ensure consistency with other definitions.
Comment on lines
+195
to
+196
| - name: google-cloud-agentregistry | ||
| apis: |
Contributor
There was a problem hiding this comment.
The new library google-cloud-agentregistry is missing the version field. To maintain consistency with other library definitions in this file, please add the version field matching the 0.0.0 version specified in .release-please-manifest.json.
- name: google-cloud-agentregistry
version: 0.0.0
apis:
suztomo
force-pushed
the
before-agentregistry
branch
from
e466b2f to
bdd87d7
Compare
These changes come from "librarian add" command with the enhancement of managing Release Please files by Librarian. ``` suztomo@suztomo:~/librarian-2026/librarian$ go build -o /tmp/librarian ./cmd/librarian suztomo@suztomo:~/librarian-2026/librarian$ cd ../google-cloud-node suztomo@suztomo:~/librarian-2026/google-cloud-node$ git checkout -b before-agentregistry 51f4a30 suztomo@suztomo:~/librarian-2026/google-cloud-node$ /tmp/librarian add google/cloud/agentregistry/v1 ``` 51f4a30 was the parent commit of the commit that added the agentregistry package in google-cloud-node.
suztomo
force-pushed
the
before-agentregistry
branch
from
bdd87d7 to
33ff142
Compare
suztomo
added a commit
to googleapis/librarian
that referenced
this pull request
Jun 30, 2026
We had to manally add Release Please entry in the configuration files when we onboard a new library to google-cloud-node. googleapis/google-cloud-node#8693 is the example. Let's have Librarian to add the entries in the Release Please files. Python and Go already have the feature with the "bulk" files. Let's make the logic work for google-cloud-node's configuration files. They use the default names: release-please-config.json and .release-please-manifest.json. Note that when Librarian starts to touch the Release Please files, it sorts the JSON keys. googleapis/google-cloud-node#8777 is the outcome of an example invocation for the agentregistry package using the source tree before the package was introduced. The JSON keys are sorted. (The irrelevant changes in the mixin fields are due to recent change in Librarian for NodeJS.) Fixes #6528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes come from "librarian add" command with the enhancement
of managing Release Please files by Librarian.
51f4a30 was the parent commit of
the commit that added the agentregistry package in google-cloud-node.