Skip to content

chore: migrate google-cloud-sql to librarian#8780

Draft
JoeWang1127 wants to merge 6 commits into
googleapis:mainfrom
JoeWang1127:chore/migrate-google-cloud-sql
Draft

chore: migrate google-cloud-sql to librarian#8780
JoeWang1127 wants to merge 6 commits into
googleapis:mainfrom
JoeWang1127:chore/migrate-google-cloud-sql

Conversation

@JoeWang1127

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Cloud SQL Admin API client library by introducing a new bidirectional streaming service, SqlDataService, and adding support for resolving connect settings. It also updates proto definitions for v1 and v1beta4 with new configuration options, including Private Service Connect (PSC) DNS automation, service connection policies, accelerated replica modes, developer editions, expanded database versions (PostgreSQL 19/20 and SQL Server 2025), and advanced Performance Capture configurations. Feedback on the changes suggests reverting the release_level of @google-cloud/sql from preview back to stable in .repo-metadata.json to avoid affecting automated release processes.

"library_type": "GAPIC_AUTO",
"name": "sqladmin",
"name_pretty": "Cloud SQL Admin",
"release_level": "preview",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The release_level for @google-cloud/sql is changed from stable to preview. Since this package is already stable, changing it to preview is likely a mistake and could affect automated release processes and documentation badges. Please revert this to stable.

Suggested change
"release_level": "preview",
"release_level": "stable",

@JoeWang1127 JoeWang1127 force-pushed the chore/migrate-google-cloud-sql branch from 248a1f3 to 5b5c3dc Compare June 30, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant