docs(storage): add comprehensive JSDoc documentation to GetSignedUrlConfig interface properties#8782
Draft
thiyaguk09 wants to merge 2 commits into
Draft
Conversation
…onfig interface properties
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds detailed JSDoc documentation to the properties of the GetSignedUrlConfig interface in handwritten/storage/src/file.ts. The review feedback recommends clarifying the documentation in two areas: first, by explicitly noting that promptSaveAs takes precedence over and overrides responseDisposition if both are provided; and second, by correcting the description of queryParams to specify that only query parameters starting with x-goog- are included in the signature for V4 signed URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #7352