Skip to content

feat(bigtable): sweep stale accelerator daemon tempdirs at startup #18688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutianf merged 3 commits into from
Oct 23, 2026
Merged

feat(bigtable): sweep stale accelerator daemon tempdirs at startup #18688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80021ec
feat(bigtable): sweep stale accelerator daemon tempdirs at startup
mutianf Oct 21, 2026
d6db158
fix(bigtable): bound the tempdir sweep, clean up on metadata write fa…
mutianf Oct 22, 2026
2fbb384
fix(bigtable): only sweep a tempdir when its spawner is provably gone
mutianf Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
264 changes: 249 additions & 15 deletions packages/google-cloud-bigtable/google/cloud/bigtable/data/_accelerator/_daemon.py
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/google-cloud-bigtable/google/cloud/bigtable/data/_accelerator/_fallback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@
import threading
from typing import TYPE_CHECKING

from grpc import RpcError, StatusCode

from google.api_core import exceptions as core_exceptions
from grpc import RpcError, StatusCode
Comment thread
mutianf marked this conversation as resolved.

if TYPE_CHECKING:
from google.cloud.bigtable.data._accelerator._daemon import AcceleratorDaemon
Expand Down
14 changes: 7 additions & 7 deletions packages/google-cloud-bigtable/google/cloud/bigtable/data/_async/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@
from google.protobuf.message import Message
from grpc import Channel

from google.cloud.bigtable.data._accelerator._daemon import AcceleratorDaemon
from google.cloud.bigtable.data._accelerator._fallback import (
AcceleratorBreaker,
_AcceleratorFallback,
handle_accelerator_error,
)
from google.cloud.bigtable.data._accelerator._routing import is_supported
from google.cloud.bigtable.data._cross_sync import CrossSync
from google.cloud.bigtable.data._helpers import (
_CONCURRENCY_LIMIT,
Expand Down Expand Up @@ -113,13 +120,6 @@
ReadModifyWriteRowRequest,
SampleRowKeysRequest,
)
from google.cloud.bigtable.data._accelerator._daemon import AcceleratorDaemon
from google.cloud.bigtable.data._accelerator._fallback import (
AcceleratorBreaker,
_AcceleratorFallback,
handle_accelerator_error,
)
from google.cloud.bigtable.data._accelerator._routing import is_supported

if CrossSync.is_async:
from grpc.aio import insecure_channel
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-bigtable/tests/unit/data/test_accelerator_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@

import google.cloud.bigtable
from google.cloud.bigtable.data._async.client import (
_UNSET,
BigtableDataClientAsync,
_AcceleratorIdentityError,
_DataApiTargetAsync,
_UNSET,
)


Expand Down
Loading
Loading