Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a background health monitor for the accelerator daemon in the Google Cloud Bigtable Python client. It adds a hand-rolled gRPC health check codec to avoid external dependencies, updates the AcceleratorBreaker to support a reversible 'degraded' state alongside the permanent 'tripped' state, and implements a background polling loop (_AcceleratorHealthMonitor) in both async and sync clients to dynamically route traffic away from the daemon if it becomes unresponsive. Comprehensive unit tests are also added to verify the codec, state machine, and polling behavior. There are no review comments, so we have no feedback to provide.
6195476 to
8fa298b
Compare
237ae46 to
040de72
Compare
sushanb
left a comment
There was a problem hiding this comment.
LGTM. All three of my prior inline suggestions landed verbatim (metrics.close placement, dead except branch removed, Event-pair breaker keeping bypass() lock-free). The health-monitor rework (ThreadPool→daemon Thread, weakref.finalize for request_stop, bounded-wait close) is a solid tightening — nothing new to flag.
… checks fix(bigtable): lock all reads and writes in AcceleratorBreaker Change-Id: I9d1daffbe086788481d6802cec035a3d4d284729
…, clear stale auth_secret on teardown Change-Id: I02c7ecb2d9ac5aa082bec0dc3325938b621bd210
Change-Id: I6665fec71ca24efe8ec47f95a71de6dda59abe5e
…), and breaker lock Change-Id: I21cf617dbea7aa85dc7b0d093e15c1ea22c7f95c
…degraded on exit Change-Id: I99ce4c0ffb7b12a3f1746801ddcadc4294f61b17
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
Stack created with GitHub Stacks CLI • Give Feedback 💬