Skip to content

fix: add missing dependency google-cloud-apphub and google-cloud-config - #18826

Merged
parthea merged 1 commit into
mainfrom
parthea-patch-16
Oct 23, 2026
Merged

parthea merged 1 commit into
mainfrom
parthea-patch-16

Conversation

@parthea

@parthea parthea commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Towards b/577038296

https://pypi.org/project/google-cloud-apphub/0.5.2/
https://pypi.org/project/google-cloud-config/0.7.2/

This change is needed so that the generated setup.py for the library google/cloud/designcenter/v1 pulls the cross api dependencies from PyPI.

See the code here which uses _pypi_packages.j2

See the cross API dependencies in the BUILD file upstream

py_import(
    name = "apphub_v1",
    srcs = ["//google/cloud/apphub/v1:apphub_py_gapic"],
)

py_import(
    name = "config_v1",
    srcs = ["//google/cloud/config/v1:config_py_gapic"],
)

py_gapic_library(
    name = "designcenter_py_gapic",
    srcs = [":designcenter_proto"],
    grpc_service_config = "designcenter_v1_grpc_service_config.json",
    opt_args = ["proto-plus-deps=google.cloud.apphub.v1+google.cloud.config.v1"],
    rest_numeric_enums = True,
    service_yaml = "designcenter_v1.yaml",
    transport = "grpc+rest",
    deps = [
        ":apphub_v1",
        ":config_v1",
        "//google/iam/v1:iam_policy_py_proto",
    ],
)

@parthea
parthea requested a review from a team as a code owner October 23, 2026 14:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PyPI packages template to include allowed version mappings for 'google-cloud-apphub' and 'google-cloud-config'. There are no review comments, and I have no feedback to provide.

@parthea
parthea merged commit fc3a527 into main Oct 23, 2026
206 of 208 checks passed
@parthea
parthea deleted the parthea-patch-16 branch October 23, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants