Skip to content

feat(storage): support initial payload in bidi_write transport - #6489

Merged
vsharonlynn merged 3 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-transport
Aug 26, 2026
Merged

feat(storage): support initial payload in bidi_write transport#6489
vsharonlynn merged 3 commits into
googleapis:mainfrom
vsharonlynn:bidi-open-and-append-transport

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

Issue #5716 .

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to send an initial chunk of data when opening an appendable object in a bidirectional write stream, updating the connector, state, and transport layers to support and test this flow. The review feedback points out that the newly added public methods connect_open_and_append and new_open_and_append lack documentation, violating the repository style guide which requires all public items to be documented with ///.

Comment thread src/storage/src/storage/bidi_write/connector.rs
Comment thread src/storage/src/storage/bidi_write/transport.rs
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.36830% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.36%. Comparing base (c4c8d56) to head (0237a51).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/bidi_write/connector.rs 97.28% 5 Missing ⚠️
src/storage/src/storage/bidi_write/state.rs 99.05% 1 Missing ⚠️
src/storage/src/storage/bidi_write/transport.rs 99.28% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6489      +/-   ##
==========================================
+ Coverage   96.34%   96.36%   +0.01%     
==========================================
  Files         295      295              
  Lines       83478    83850     +372     
==========================================
+ Hits        80429    80800     +371     
- Misses       3049     3050       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn marked this pull request as ready for review August 21, 2026 06:31
@vsharonlynn
vsharonlynn requested review from a team as code owners August 21, 2026 06:31
Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/state.rs Outdated
Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated
Comment thread src/storage/src/storage/bidi_write/transport.rs Outdated
Comment thread src/storage/src/storage/bidi_write/state.rs Outdated
Comment thread src/storage/src/storage/bidi_write/connector.rs
Comment thread src/storage/src/storage/bidi_write/transport.rs
Comment thread src/storage/src/storage/bidi_write/transport.rs
Comment thread src/storage/src/storage/bidi_write/transport.rs

@xlai20 xlai20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with an unresolved comment.

Comment thread src/storage/src/storage/bidi_write/connector.rs
@vsharonlynn
vsharonlynn merged commit 30c6e15 into googleapis:main Aug 26, 2026
42 checks passed
@vsharonlynn
vsharonlynn deleted the bidi-open-and-append-transport branch August 26, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants