Skip to content

impl(gax-internal): support server-side streaming - #6504

Merged
suzmue merged 1 commit into
googleapis:mainfrom
suzmue:server-streaming
Aug 24, 2026
Merged

impl(gax-internal): support server-side streaming#6504
suzmue merged 1 commit into
googleapis:mainfrom
suzmue:server-streaming

Conversation

@suzmue

@suzmue suzmue commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Add the execute_server_streaming helper on the gRPC transport client to support server-side streaming RPCs. The helper handles converting domain requests to proto messages and decodes the response stream using decode_response_stream into a ResponseReceiver.

Gate server streaming execution helpers under the
google_cloud_unstable_gapic_streaming cfg.

Enable include_server_streaming_methods for Showcase in librarian.yaml, regenerate google-cloud-showcase-v1beta1, and add integration tests for server-side streaming.

For #2318

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for server-side streaming RPCs in the Rust SDK. It implements execute_server_streaming in the internal gRPC client, adds unimplemented server streaming stubs, and updates the generated showcase client, builders, and transport layers to support streaming methods like expand, stream_blurbs, and attempt_streaming_sequence. Comprehensive integration and unit tests are also included. The review feedback recommends using the fully qualified path google_cloud_gax::streaming::decode_response_stream in src/gax-internal/src/grpc.rs to ensure consistency with the fully qualified ResponseReceiver type used nearby.

Comment thread src/gax-internal/src/grpc.rs
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (2b3004b) to head (294eabb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6504   +/-   ##
=======================================
  Coverage   96.39%   96.40%           
=======================================
  Files         301      301           
  Lines       84769    84807   +38     
=======================================
+ Hits        81714    81755   +41     
+ Misses       3055     3052    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue
suzmue marked this pull request as ready for review August 22, 2026 00:32
@suzmue
suzmue requested review from a team as code owners August 22, 2026 00:32

@coryan coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat. I think you may be making progress towards some of these: #2202, #2204 #2205, #2206 and may have even fixed them. If you did, please close the issues.

Add the execute_server_streaming helper on the gRPC transport client to
support server-side streaming RPCs. The helper handles converting domain
requests to proto messages and decodes the response stream using
decode_response_stream into a ResponseReceiver.

Gate server streaming execution helpers under the
google_cloud_unstable_gapic_streaming cfg.

Enable include_server_streaming_methods for Showcase in librarian.yaml,
regenerate google-cloud-showcase-v1beta1, and add integration tests for
server-side streaming.
@suzmue
suzmue enabled auto-merge (squash) August 24, 2026 17:30
@suzmue
suzmue merged commit 5990bfa into googleapis:main Aug 24, 2026
42 checks passed
@suzmue
suzmue deleted the server-streaming branch August 24, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants