impl(workspace): migrate from chrono to jiff - #6516
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request replaces the chrono dependency with jiff across multiple crates for date and time handling. The reviewer pointed out several instances where jiff::Timestamp::strftime is used incorrectly; since it returns a Result, calling .to_string() or formatting it directly will fail to compile. The feedback suggests using .expect("valid format") to safely unwrap the infallible result before formatting.
|
Please let us know when you have signed the CLA, we cannot proceed without that. /gcbrun |
|
/gdbrun |
|
/gcbrun |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 301 301
Lines 84762 84764 +2
=======================================
+ Hits 81706 81711 +5
+ Misses 3056 3053 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chrono to jiff|
Sorry, I didn't notice you updated the PR title. I updated the commit message and the PR title to match. Let me know if you want any changes. I signed the CLA. |
|
/gcbrun |
|
Don't worry about the mismatch between title and commit message, that is just reminder (or an annoyance, depending on how I feel that day). |
|
The CI error is: I suspect it is a problem in the build or how we use Thanks for the PR and your patience. |
|
/gcbrun |
As discussed in #1153 (comment) and onward, this replaces the internal usages of
chronoin this workspace withjiff. TheTryFromimpls inwktforTimestampthat convert to and fromchrono::DateTime<chrono::Utc>are left in place.