refactor(gax): consolidate grpc-rust test mocks - #6519
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC test helpers by consolidating common mock implementations—such as MockSendStream, MockRecvStream, MockInvoker, and FailAfterFirstSendStream—from bidi.rs and unary.rs into a shared testing.rs module, reducing code duplication. The review feedback suggests simplifying MockInvoker by removing an unnecessary Arc wrapper around observed_headers and using TestMessage::new in bidi.rs to maintain consistency across tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## grpc_rust #6519 +/- ##
===========================================
Coverage 96.42% 96.42%
===========================================
Files 307 307
Lines 86490 86331 -159
===========================================
- Hits 83397 83245 -152
+ Misses 3093 3086 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dcf5c01 to
dcaef89
Compare
For #5991.