Repository navigation
feat(spanner): add send_message and ack_message to Transaction - #263
Open
torreypayne wants to merge 9 commits into
Open
torreypayne wants to merge 9 commits into
torreypayne wants to merge 9 commits into
Conversation
torreypayne
added this pull request to stack #266
October 12, 2026 19:55
This was referenced Oct 12, 2026
torreypayne
force-pushed
the
queues/3-transaction
branch
from
October 13, 2026 20:11
1848a13 to
e66ffce
Compare
torreypayne
marked this pull request as ready for review
October 13, 2026 20:17
torreypayne
force-pushed
the
queues/3-transaction
branch
from
October 14, 2026 15:34
e66ffce to
3968a83
Compare
torreypayne
force-pushed
the
queues/3-transaction
branch
from
October 19, 2026 23:40
3968a83 to
7de6dc2
Compare
…arguments Replace the SendOptions and AckOptions classes with keyword arguments, as agreed on #262. Adding an optional keyword later doesn't break callers, and an unknown keyword still raises ArgumentError. Also fix the key_list_value doc: it converts one key, not a list of keys.
# Conflicts: # google-cloud-spanner/lib/google/cloud/spanner/ack_options.rb # google-cloud-spanner/lib/google/cloud/spanner/send_options.rb
Transaction#send_message and #ack_message now take deliver_time: and ignore_not_found: and pass them to the transaction's Commit, matching the keyword arguments on Commit.
The examples wrapped text in a StringIO, which is only right for a queue with a BYTES payload column. On a STRING column the gem would send the Base64 text. Use a String and say the queue's payload column is STRING(MAX), and add a separate BYTES example that wraps binary data.
…xample Match the Commit#send_message examples: pass a String and say the queue's payload column is STRING(MAX), instead of wrapping text in a StringIO, which is only right for a BYTES payload column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Transaction#send_messageandTransaction#ack_message, so queue writes commit atomically with table writes. Both delegate to the transaction'sCommitand take the samedeliver_time:andignore_not_found:keywords. The newClient#transactiontest covers a transaction with only queue mutations, where the first one becomes theBeginTransactionmutation key.Part 3 of 5, split out of #260.