Repository navigation
Conversation
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
Collaborator
Author
|
Folded into #7, together with a 60s request timeout. On its own this PR fixed the coroutines crash, but the Gemini request then hit CIO's 15s timeout, and Ktor's timeout message includes the request URL, which still carried the API key. #7 moves the key into a header, so the fixes have to land together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run-instrumentation-testfails onmain(and so on every open PR, including docs-only #6):VisualMapSampleTestcrashes as soon as the Gemini path makes a request.:visual-testingpulls in Ktor 3.6.0, which needskotlinx-coroutines1.11. The sample app's runtime classpath resolves coroutines 1.9.0 through its AndroidX dependencies, and AGP pins the test APK to the app's runtime versions (kotlinx-coroutines-core:{strictly 1.9.0}), so Ktor runs against 1.9 on the device.This adds
kotlinx-coroutines-android(the existingcoroutinesversion, 1.11.0) to the sample app.debugAndroidTestRuntimeClasspathnow resolves{strictly 1.11.0}.Any consumer app still on coroutines older than 1.11 hits the same crash when using
:visual-testing. That is a reason to drop Ktor from the library, which I'll raise separately since it changes the public constructor.Ran
:app:assembleDebug :app:assembleDebugAndroidTest :app:testDebugUnitTest spotlessCheck lintlocally: green. The emulator run on this PR is the real check, since I could not run it locally.