Repository navigation
Conversation
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build and the sample app still carry the names from when this was an internal Robolectric prototype:
rootProject.name:AndroidMapsRobolectric->android-maps-testing(matches the repo).namespaceandapplicationId:com.example.androidmapsrobolectric->com.google.maps.android.testing.sample.AndroidMapsRobolectricTheme/Theme.AndroidMapsRobolectric/ "AndroidMapsRobolectric" ->MapsTestingSampleTheme/Theme.MapsTestingSample/ "Maps Testing Sample".#Lx-Lyregion link against its[START]/[END]tags.Only
:appchanges. No published artifact, package or API is affected. The three library modules still use their current packages, and movingrobolectric-testingfromcom.google.maps.android.robolectricto...testing.robolectricis left for a separate decision, since rc01 is already on Maven Central.The skill templates keep their
com.example.maptest.templatesplaceholder package on purpose.One thing to check: the instrumentation job builds the sample with
ACTIONS_API_KEY. If that key has an Android application restriction tied tocom.example.androidmapsrobolectric, the map will not render under the newapplicationId. The emulator run on this PR will show it either way.Conflicts with #7: both touch
VisualMapSampleTest.ktand its skill links. Whichever merges second needs a rebase; it is mechanical.Ran
./gradlew test lint spotlessCheck apiCheck docs:dokkaGenerate assembleDebug: all green.