Skip to content

chore: rename root project and sample app away from the prototype names - #9

Open
kikoso wants to merge 1 commit into
mainfrom
chore/rename-sample-app
Open

kikoso wants to merge 1 commit into
mainfrom
chore/rename-sample-app

Conversation

@kikoso

@kikoso kikoso commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

The build and the sample app still carry the names from when this was an internal Robolectric prototype:

  • rootProject.name: AndroidMapsRobolectric -> android-maps-testing (matches the repo).
  • Sample app package, namespace and applicationId: com.example.androidmapsrobolectric -> com.google.maps.android.testing.sample.
  • Sample theme and app name: AndroidMapsRobolectricTheme / Theme.AndroidMapsRobolectric / "AndroidMapsRobolectric" -> MapsTestingSampleTheme / Theme.MapsTestingSample / "Maps Testing Sample".
  • Skill and reference links that point into the sample sources now use the new paths. Line numbers are unchanged, and I checked every #Lx-Ly region link against its [START]/[END] tags.

Only :app changes. No published artifact, package or API is affected. The three library modules still use their current packages, and moving robolectric-testing from com.google.maps.android.robolectric to ...testing.robolectric is left for a separate decision, since rc01 is already on Maven Central.

The skill templates keep their com.example.maptest.templates placeholder package on purpose.

One thing to check: the instrumentation job builds the sample with ACTIONS_API_KEY. If that key has an Android application restriction tied to com.example.androidmapsrobolectric, the map will not render under the new applicationId. The emulator run on this PR will show it either way.

Conflicts with #7: both touch VisualMapSampleTest.kt and its skill links. Whichever merges second needs a rebase; it is mechanical.

Ran ./gradlew test lint spotlessCheck apiCheck docs:dokkaGenerate assembleDebug: all green.

@snippet-bot

snippet-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 19 region tags.
You are about to delete 19 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Coverage (unit tests)

No unit baseline recorded in coverage/history.csv yet, so this run only reports absolute numbers.

Module Line % Change Branch % Change
golden-testing 90.42% new 58.00% new
robolectric-testing 84.06% new 51.87% new
visual-testing 36.54% new 25.07% new
TOTAL 78.88% new 44.10% new

Line and branch coverage from unit test reports. History is recorded in coverage/history.csv after each merge to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants