feat(clustering): make ClusterManager and public API open with JvmSuppressWildcards - #1759
Open
dkhawk wants to merge 1 commit into
Open
feat(clustering): make ClusterManager and public API open with JvmSuppressWildcards#1759dkhawk wants to merge 1 commit into
dkhawk wants to merge 1 commit into
Conversation
…mSuppressWildcards
Contributor
Code Coverage
Files
|
Collaborator
|
Could we add some tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
ClusterManagerand its public API methods/propertiesopento restore subclassing and test double capabilities following the Kotlin migration. Adds@JvmSuppressWildcardsannotations to generic collection arguments (addItems,removeItems,diff) for clean Java interop without wildcard variance collisions.Changes
ClusterManagerasopen class ClusterManager<T : ClusterItem>openmodifier to all public properties, methods, and listeners (renderer,algorithm,setAlgorithm,setAnimation,clearItems,addItem,addItems,updateItem,removeItem,removeItems,diff,cluster,onCameraIdle,onMarkerClick,onInfoWindowClick,setOnClusterClickListener, etc.)@JvmSuppressWildcardsto generic collection arguments (Collection<@JvmSuppressWildcards T>) inaddItems,removeItems, anddiffReviewer
cc @LoyalAbbas